onivim/oni

Keybinding Mechanism isn't Robust

Open

#1,240 opened on Jan 6, 2018

View on GitHub
 (7 comments) (0 reactions) (0 assignees)TypeScript (336 forks)batch import
bughelp wanted

Repository metrics

Stars
 (11,389 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

const activate = (oni) => {
    console.log("config activated")

    // Input 
    //
    // Add input bindings here:
    //
    oni.input.bind("<c-enter>", () => console.log("Control+Enter was pressed"))
    oni.input.bind("<c-s-r>", "language.findAllReferences")

    //
    // Or remove the default bindings here by uncommenting the below line:
    //
    // oni.input.unbind("<c-p>")
}

I input <c-enter> , there is no any output on developer console I input <c-s-r>, there is no any response.

Contributor guide

Research direction
Inspect the keybinding handler registration and event propagation for <c enter> and <c s r>.
Tech stack
typescript
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Basic knowledge of Oni keybinding system
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60