onivim/oni

Question: Combine LSP and vim autocomplete menus

Open

#1221 opened on Jan 3, 2018

View on GitHub
 (5 comments) (1 reaction) (0 assignees)TypeScript (11,389 stars) (336 forks)batch import
enhancementhelp wantedinsider

Description

@bryphe at present if a user wanted to use both the autocompletion from a vim plugin as well as that of Oni's LSP two conflicting menus are opened. I'm not sure what you're take on this is but I think that it would be preferable if the output of all autocompletion was merged into one menu so a user has the option of using whatever source they would like rather than disabling one in the favour of the other. Potentially with a configuration option to set priority of the output to either be in vim's plugins favour or the lsp.

I'm not sure currently how each is implemented or how feasible this is as likely they are triggered by separate events so two different instances of the menu are created but I'm wondering whether or not the menu could be setup to reuse instances and just add pagination and maybe some ui clue as to the different sources being used.

This is something I could look at in the future if you're not opposed to it but I'd like to get your take on this as there is likely plenty I haven't accounted for.

Contributor guide

Tech stack
typescript
Domain
frontenddeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
LSP protocolvim autocompleteOni codebaseTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
15
Research direction
Investigate the Oni codebase to understand how LSP and vim autocomplete menus are currently implemented. Look at the UI component responsible for rendering the autocomplete menu and see if it can be extended to accept multiple sources. Examine any existing configuration options for autocomplete. Check for comments or linked issues that discuss this feature.