onivim/oni

Add more tests

Open

#1128 opened on Dec 14, 2017

View on GitHub
 (11 comments) (1 reaction) (0 assignees)TypeScript (11,389 stars) (336 forks)batch import
enhancementhelp wanted

Description

Couldn't find an issue directly addressing this, but it would be pretty nice, if not essential, that there's a good testing framework for making sure that changes do not regress the code. I understand that while the code is still in flux testing does not matter that much, but given that there is already quite a rich and working feature set, it'd be a shame if it became buggy.

Personally, I think Jest is the best testing framework in this context because of its integration with React components. Have to admit I haven't used it myself, though.

Contributor guide

Tech stack
typescriptreactjest
Domain
testingfrontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic knowledge of Jest and ReactUnderstanding of testing in JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Review the existing codebase to understand component structure. Set up Jest with React testing library. Write initial unit tests for core UI components. See comments in issue #1128 for discussion on testing frameworks.