olistic/warriorjs

Check if unit is alive after effects

Open

#63 opened on May 8, 2018

View on GitHub
 (8 comments) (0 reactions) (0 assignees)JavaScript (9,168 stars) (528 forks)batch import
good first issuepkg: corestatus: claimedtype: enhancement

Description

A negative effect could potentially kill a unit. We need to check if the unit is still alive after executing the effects and return early if the unit died. Example: a "poisoned" effect (it doesn't exist, at least yet) that damages the unit turn by turn.

Contributor guide

Tech stack
javascript
Domain
backend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with WarriorJS game logicUnderstanding of Unit.js effects execution
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
Examine the Unit.js file in packages/warriorjs core/src, specifically the method that executes effects around line 98. Understand the current flow and add a check after calling the effects to verify the unit's health. If health is 0 or below, cause the unit to die or return early. This is a small localized change.