olimorris/neotest-phpunit

Support data sets in data provider

Open

#23 opened on Mar 31, 2024

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Lua (38 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (54 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Even primitive detection (without pointing the method the provider belongs to) of yielded keys as named dataset

    (yield_expression
      (array_element_initializer
        (string
          (string_value) @dataset )))

could prove helpful in tests where yield is used in data provider.

At the moment I need some free time to answer myself how to pass the data set here https://github.com/olimorris/neotest-phpunit/blob/5799a4ea84450af14461d24edbde43913f9b3008/lua/neotest-phpunit/init.lua#L137-L141 or into any better place and (optionally) how to list detected data set on the summary view. Any hints (as well as PR) can be helpful.

Contributor guide

Research direction
Examine the linked repository's init.lua to understand how tests are discovered and see where dataset parsing could be added. Look into PHP parsing libraries or tree sitter queries for detecting yield expressions in PHP files.
Tech stack
lua
Domain
testing qa
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
LuaNeovimPHPUnit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50