ogaclejapan/SmartTabLayout

Always in Center is not in Center

Open

#53 opened on Jul 23, 2015

View on GitHub
 (18 comments) (0 reactions) (0 assignees)Java (7,048 stars) (1,362 forks)batch import
bughelp wanted

Description

Im implementing the always in center style and i can't get it to be centered. Whats weird is if i rotate landscape then back portrait it is then centered like it should be.

<com.ogaclejapan.smarttablayout.SmartTabLayout
            android:id="@+id/tabs"
            android:layout_width="match_parent"
            android:layout_height="48dp"
            android:paddingBottom="4dp"
            app:stl_indicatorAlwaysInCenter="true"
            app:stl_indicatorWithoutPadding="false"
            app:stl_indicatorInFront="false"
            app:stl_indicatorInterpolation="smart"
            app:stl_indicatorGravity="bottom"
            app:stl_indicatorColor="@color/accent2"
            app:stl_indicatorThickness="4dp"
            app:stl_indicatorCornerRadius="0dp"
            app:stl_overlineColor="#4D000000"
            app:stl_overlineThickness="0dp"
            app:stl_underlineThickness="1dp"
            app:stl_dividerColor="#00000000"
            app:stl_dividerThickness="1dp"
            app:stl_defaultTabTextAllCaps="true"
            app:stl_defaultTabTextColor="@color/app_tab_text"
            app:stl_underlineColor="@color/transparent"
            app:stl_defaultTabBackground="?attr/selectableItemBackground"
            app:stl_defaultTabTextSize="14sp"
            app:stl_defaultTabTextMinWidth="120dp"
            app:layout_scrollFlags="enterAlways"/>

Issue

Contributor guide

Tech stack
javaandroid
Domain
mobile
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Android custom view knowledgeSmartTabLayout codebase
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the indicator drawing logic in SmartTabLayout, particularly the 'indicatorAlwaysInCenter' option. The bug suggests a timing issue during initial layout. Start by reviewing the onDraw or onLayout methods in the library's source, focusing on how the indicator position is calculated. Check if the indicator center aligns correctly when first displayed, and consider using debugging logs or a minimal test project to reproduce the issue. Also look at the GitHub issue comments for any hints.