oddbird/css-anchor-positioning

`elements` option should find inline styles on descendent elements

Open

#289 opened on Jan 15, 2025

View on GitHub
 (0 comments) (3 reactions) (0 assignees)TypeScript (18 forks)auto 404
enhancementgood first issue

Repository metrics

Stars
 (489 stars)
PR merge metrics
 (PR metrics pending)

Description

Is your feature request related to how this polyfill works? Please describe.

Given this HTML

<div id="wrapper">
  <div id="anchor" style="anchor-name: --a">A</div>
  <div id="target" style="position-anchor: --a">A</div>
</div>

and calling:

polyfill({elements: [wrapper], excludeInlineStyles: true})

Inline styles on #anchor and #target are not polyfilled. It would be useful to not have to pass each individual element, but instead just the wrapper.

Describe the solution you'd like

Adjust the polyfill so that if an element is passed, it AND its entire subtree are evaluated for inline anchor styles.

Describe alternatives you've considered

We could make this opt in, perhaps with a includeChildInlineStyles or an alternate to elements, but I think it's unlikely that people will want to not polyfill children.

Additional context Codepen Repro

Contributor guide

Research direction
Examine how the polyfill currently processes `elements` and modify the logic to recursively traverse child elements for inline anchor styles. Consider adding a check for `excludeInlineStyles` and ensure that the subtree is included by default. Update tests to cover nested inline styles.
Tech stack
typescript
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScriptDOM
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70