Python 3.14 emits SyntaxWarning for return in finally block

Open Beginner friendly
#74 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
84/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
python
Domain
api

Research direction

Start in pyobvector/client/ob_vec_json_table_client.py around line 799 and inspect the cleanup and return flow in the finally block. Reproduce the import warning on Python 3.14, then verify that the warning is gone and exceptions from the try block are not suppressed; update the compatibility matrix if it is part of the change.

Written by the indexing model from the issue text.

Description

Importing pyobvector 0.2.28 on Python 3.14 emits a SyntaxWarning because ob_vec_json_table_client.py returns from a finally block.

Reproduction:

.../site-packages/pyobvector/client/ob_vec_json_table_client.py:799: SyntaxWarning: 'return' in a 'finally' block
  return n_new_records

This is non-fatal on the normal path, but a return in finally can suppress exceptions from the try block. It also makes CLIs that import the package appear broken. Please move the return after cleanup (or otherwise avoid returning from finally) and consider Python 3.14 in the compatibility matrix.

Dominant language
Python
Stars
19
Forks
12
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from oceanbase/pyobvector

All issues in oceanbase/pyobvector

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.