oceanbase/miniob

去掉CONCURRENCY编译条件

Open

#489 opened on Nov 21, 2024

View on GitHub
 (2 comments) (0 reactions) (1 assignee)C++ (1,622 forks)auto 404
enhancementgood first issuehelp wanted

Repository metrics

Stars
 (4,387 stars)
PR merge metrics
 (PR metrics pending)

Description

Enhancement 当miniob 加上 CONCURRENCY 编译条件之后才会编译出多线程可用的程序。当时这么设计是为了简化程序，特别是对于新手，单线程的程序会更加容易上手。但是现在代码越来越难维护，而且如果测试题目都是单线程时，死锁的调试也是比较容易的，因此默认编译并发，也就是去掉 CONCURRENCY 编译条件没有什么问题。

Contributor guide

Research direction
Remove the CONCURRENCY preprocessor condition and ensure multi threaded compilation is the default. Update any conditional code paths and verify tests still pass.
Tech stack
ccpp
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++CMake
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80