ocaml/dune

Exit with code 0 when using —auto-promote

Open

#785 opened on May 19, 2018

View on GitHubContributor guide
 (2 comments) (2 reactions) (1 assignee)OCaml (478 forks)github user discovery
clihelp wanted

Repository metrics

Stars
 (1,882 stars)
PR merge metrics
 (Avg merge 1d 20h) (345 merged PRs in 30d)

Description

Running jbuilder build @settests --auto-promote where it is expected to promote a revised test/jbuild.inc file, but one ends up having to do sh -c "jbuilder build @settests --auto-promote || true" in, say, an opam file in order to skip the error.

It would be great if Dune returned exit code 0 when —auto-promote has been specified (assuming a fixed point in the build has been reached)

Contributor guide

Research direction
Investigate the exit code handling in the promotion logic of Dune. Look for where auto promote flag influences the exit code. Trace the code path to ensure that when promotion succeeds and a fixed point is reached, the exit code is 0.
Tech stack
None
Domain
build system
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
OCamlDuneGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70