ocaml/dune

Dependency analysis: Unnecessary/undesired compilation unit included in executable

Open

#753 opened on May 8, 2018

View on GitHubContributor guide
 (13 comments) (0 reactions) (0 assignees)OCaml (478 forks)github user discovery
help wantedwontfix

Repository metrics

Stars
 (1,882 stars)
PR merge metrics
 (Avg merge 1d 20h) (345 merged PRs in 30d)

Description

There seems to be the following problem:

open Hellolib;;
Hello.hello ()  (* = Hellolib.Hello.hello () *)

results in any local hello.ml to be compiled and linked against our executable, even though we don't use this Hello in this particular program.

Suggested workaround: Rename the local hello.ml, e.g. hello_main.ml.

See https://github.com/mjambon/dune-dependencies for exact reproduction details.

Contributor guide

Research direction
Investigate the dependency analysis logic in Dune that causes the local hello.ml to be compiled and linked when Hellolib is opened. Trace how modules are resolved and why an unused module is included.
Tech stack
None
Domain
build system
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
OCamlDune
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40