ocaml/dune

Add support for assembly language for foreign_stubs

Open

#3,342 opened on Apr 8, 2020

View on GitHubContributor guide
 (3 comments) (0 reactions) (0 assignees)OCaml (478 forks)github user discovery
good first issue

Repository metrics

Stars
 (1,882 stars)
PR merge metrics
 (Avg merge 1d 20h) (345 merged PRs in 30d)

Description

The doc for foreign_stubs says:

language specifies the source language, where c means C and cxx means C++. In future, more languages may be supported.

It would be nice to add support for .S files too ; generally they can just be passed to the underlying C compiler just fine ; I'm not fully sure of what should be the assembly flags. I think keeping the flags as C by default should generally work.

Contributor guide

Research direction
Examine how dune handles foreign stubs for C and C++ languages, and extend that logic to accept assembly (.S) files. Likely just pass them to the C compiler as is, but verify flags handling.
Tech stack
ccpp
Domain
build system
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
OCamlC
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75