`benchmark-diff.sh` truncates fractional part of benchmark deltas

Open Beginner friendly
#1,493 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
88/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
awk, shell
Domain
performance, tooling

Research direction

Start with .github/benchmark-diff.sh and inspect the AWK report formatting and change-reporting logic. Compare baseline 10.4 with current 11.1, then verify that the displayed delta retains fractional precision and that the 0.7 ms change is reported.

Written by the indexing model from the issue text.

Description

bug good-title

Problem

.github/benchmark-diff.sh formats numeric deltas with %d in the AWK report. Benchmark timings can contain fractional values, so this truncates the measured change before it is shown in the comparison table.

Steps to reproduce

Compare a baseline value of 10.4 with a current value of 11.1.

Actual result

The delta is printed as an integer (0), hiding the 0.7 ms regression.

Expected result

Keep the fractional precision of benchmark measurements when printing the delta and when deciding which changes to report.

Dominant language
Java
Stars
14
Forks
39
Avg merge
21h 51m
Merged PRs (30d)
90

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from objectionary/lints

All issues in objectionary/lints

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.