nylas/nylas-mail

Don't link track tel:, skype:, etc / Disable click tracking on selected links

Open

#2,737 opened on Aug 18, 2016

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (1,370 forks)batch import
buggood-starter-issuehacktoberfest

Repository metrics

Stars
 (24,786 stars)
PR merge metrics
 (Avg merge 3h 15m) (1 merged PR in 30d)

Description

I have an email signature that deeplinks to "tel:" and "skype:". I'd like to keep link tracking on, but the link tracking does not work on the skype link when it is sent through as when the deeplink is redirected, it garbles the uri. "skype:" becomes "https://link.nylas.com/link/...?redirect=**skype%3A{username}%3Fchat**&r=cnVhZGhhbkBnbWFpbC5jb20="

It would be nice to be able to either fix this, or be able to remove tracking on specific links. Mandrill does it nicely here:

Contributor guide

Research direction
Investigate the link tracking code to understand how it constructs redirect URLs and find a way to exempt tel:, skype:, and similar URI schemes from tracking, or fix the encoding to preserve the original URI.
Tech stack
javascript
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70