nylas/nylas-mail

Default signature is inserted if no custom signature is set as default

Open

#2,697 opened on Aug 2, 2016

View on GitHub
 (8 comments) (4 reactions) (0 assignees)JavaScript (1,370 forks)batch import
enhancement-requestgood-starter-issuehacktoberfesthelp-wanted

Repository metrics

Stars
 (24,786 stars)
PR merge metrics
 (Avg merge 3h 15m) (1 merged PR in 30d)

Description

What operating system are you using?

OSX 10.11.5

What version of N1 are you using?

Version 0.4.47-3a2a94c (0.4.47-3a2a94c)

Bug?

Do you have any third-party plugins installed? If so, which

No

Is the issue related to a specific email provider (Gmail, Exchange, etc.)?

No

Is the issue reproducible with a particular attachment, message, signature, etc?
  1. Create 2 custom signatures.
  2. do not set 1 as a default signature 2016-08-02 at 09 57
  3. new emails have the default Sent from Nylas N1, the extensible, open source mail client. signature

Expected behaviour: no signature at all

Contributor guide

Research direction
Investigate the signature selection logic in the email composer to determine why the default 'Sent from Nylas N1' signature is inserted when no custom signature is set as default. Look for conditionals that fall back to this default.
Tech stack
javascriptnodejselectron
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85