nvim-neo-tree/neo-tree.nvim

BUG: fuzzy find does not take always_show into account

Open

#1453 opened on May 1, 2024

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Lua (5,436 stars) (291 forks)batch import
buggood-first-issuehelp wantedwontfix

Description

Did you check docs and existing issues?

  • I have read all the docs.
  • I have searched the existing issues.
  • I have searched the existing discussions.

Neovim Version (nvim -v)

0.9.5

Operating System / Version

linux x86-64

Describe the Bug

Filtering or fuzzy search in the neotree pane does not find files that are always_show configured. Default keybinding / for fuzzy search (I think).

Configure filesystem.filtered_items.always_show = {".gitignore"}.

The .gitignore file is visible in the default neotree view. When fuzzy finding with /, it's not possible to find the file. If I enable hidden files, then it's possible to fuzzy find it.

Screenshots, Traceback

neotree version 3.25.0 7aad1bf using lazy.nvim

Steps to Reproduce

  1. Configure filesystem.filtered_items.always_show = {".gitignore"}
  2. Verify .gitignore is always visible
  3. Use fuzzy find

Expected Behavior

.gitignore is visible in default view with this configuration so it's expected to be findable with /

Your Configuration

NA, I'm sorry

Contributor guide

Tech stack
lua
Domain
developer experiencetooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Lua programmingNeovim plugin developmentNeo tree codebase structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Examine the fuzzy find logic in neotree, likely in the 'filter' or 'search' modules. The 'always show' configuration is applied in the file tree view but apparently not in the search filter. Investigate how filtered items are excluded from search results and ensure that files with 'always show' are included. Look at the 'filtered items' handling in the codebase.