nvbn/thefuck

Support `source ~/.bashrc` when installing

Open

#972 opened on Oct 10, 2019

View on GitHub
 (9 comments) (1 reaction) (0 assignees)Python (3,949 forks)batch import
enhancementhacktoberfesthelp wanted

Repository metrics

Stars
 (96,953 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

When you first install thefuck, you get this nice message.

$ fuck
Seems like fuck alias isn't configured!
Please put eval "$(thefuck --alias)" in your ~/.bashrc and apply changes with source ~/.bashrc or restart your shell.
Or run fuck second time for configuring it automatically.
More details - https://github.com/nvbn/thefuck#manual-installation

$ fuck
fuck alias configured successfully!
For applying changes run source ~/.bashrc or restart your shell.

Which is great and I love it, however, when I run fuck again, I get the same message.

$ fuck
fuck alias configured successfully!
For applying changes run source ~/.bashrc or restart your shell.

Seems like an oversight. It should suggest running source ~/.bashrc.

Contributor guide

Research direction
Investigate the code path that displays the 'fuck alias configured successfully!' message. Determine why the message persists even after configuration, and propose a check to ensure the alias is actually functional or prompt the user to source their shell configuration.
Tech stack
python
Domain
cli
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPython
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80