nvbn/thefuck

Doesn't handle quotes and arguments with spaces well

Open

#720 opened on Oct 27, 2017

View on GitHub
 (3 comments) (1 reaction) (0 assignees)Python (3,949 forks)batch import
HackIllinoishacktoberfesthelp wanted

Repository metrics

Stars
 (96,953 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

v3.24 using Python 3.5.3, on Ubuntu 17.04, GNU bash 4.4.7(1)-release.

Using an alias, but with no alias is indifferent:

$ theheck "catt 'My File'"
cat My File [enter/↑/↓/ctrl+c]

$ theheck "catt My\ File"
cat My File [enter/↑/↓/ctrl+c]

$ theheck "ehco -e '\n'"
echo -e \n [enter/↑/↓/ctrl+c]

$ theheck "ehco -n $'\n'"
echo -n $\n [enter/↑/↓/ctrl+c]

The debug output is here: https://pastebin.com/GjXPpQbs

Contributor guide

Research direction
Investigate how thefuck parses command arguments from the shell history or user input, specifically how it handles quotes and escaped spaces. Review the argument splitting logic and fix to properly preserve quoting.
Tech stack
python
Domain
cli
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Python
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70