nvbn/thefuck

Doesn't handle quotes and arguments with spaces well

Open

#720 opened on Oct 27, 2017

View on GitHub
 (3 comments) (1 reaction) (0 assignees)Python (96,953 stars) (3,949 forks)batch import
HackIllinoishacktoberfesthelp wanted

Description

v3.24 using Python 3.5.3, on Ubuntu 17.04, GNU bash 4.4.7(1)-release.

Using an alias, but with no alias is indifferent:

$ theheck "catt 'My File'"
cat My File [enter/↑/↓/ctrl+c]

$ theheck "catt My\ File"
cat My File [enter/↑/↓/ctrl+c]

$ theheck "ehco -e '\n'"
echo -e \n [enter/↑/↓/ctrl+c]

$ theheck "ehco -n $'\n'"
echo -n $\n [enter/↑/↓/ctrl+c]

The debug output is here: https://pastebin.com/GjXPpQbs

Contributor guide

Tech stack
pythonshell
Domain
clideveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Pythoncommand line parsing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the argument parsing in thefuck/shells/ directory, particularly how the command string is split. The issue shows that quotes and spaces are not preserved. Review the use of shlex.split or similar libraries. Check existing tests for edge cases. The debug output in the pastebin may provide clues. Look for any recent comments or PRs.