nvbn/thefuck

Hitting enter does not execute the previous command in Windows Git Bash

Open

#672 opened on Jul 28, 2017

View on GitHub
 (6 comments) (10 reactions) (0 assignees)Python (3,949 forks)batch import
hacktoberfesthelp wanted

Repository metrics

Stars
 (96,953 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

$ echo "foo'
> ^C
$ fuck
echo "foo" [enter/↑/↓/ctrl+c]
(hangs here...)

This is on Windows Git Bash (bash 4.4). thefuck --version and type fuck are below.

$ thefuck --version
The Fuck 3.18 using Python 2.7.13

$ type fuck
fuck is a function
fuck ()
{
    TF_PREVIOUS=$(fc -ln -1);
    TF_PYTHONIOENCODING=$PYTHONIOENCODING;
    export TF_ALIAS=fuck;
    export TF_SHELL_ALIASES=$(alias);
    export PYTHONIOENCODING=utf-8;
    TF_CMD=$( thefuck $TF_PREVIOUS THEFUCK_ARGUMENT_PLACEHOLDER $@ ) && eval $TF_CMD;
    export PYTHONIOENCODING=$TF_PYTHONIOENCODING;
    history -s $TF_CMD
}

Contributor guide

Research direction
Investigate the shell integration for Windows Git Bash, specifically checking how 'fc' command behaves and how 'thefuck' captures the previous command. Check if there's an issue with the 'history s' command or the way 'fuck' function parses the output.
Tech stack
python
Domain
cli
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git Bash
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75