nvbn/thefuck

Change way of interaction with shells

Open

#469 opened on Feb 29, 2016

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (96,953 stars) (3,949 forks)batch import
help wanted

Description

I guess it would be nice to:

  • put shell aliases in environment variable (TF_SHELL_ALIASES) in alias and get it from there, instead of calling shell from app (done for bash and zsh);
  • move all writes to history to alias (done for bash and zsh).

It would speedup thefuck, and probably will fix #428, #422 and #402.

Contributor guide

Tech stack
pythonshell
Domain
clideveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
familiarity with Pythonunderstanding of shell scriptingknowledge of thefuck's codebase
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue proposes refactoring shell integration by moving shell aliases to an environment variable (TF SHELL ALIASES) and moving all writes to history into the alias, which is already done for bash and zsh. To implement, examine the current shell alias setup in the codebase (likely in `thefuck/shells/`), understand the existing implementations for bash and zsh, and then generalize for other shells. Also review linked issues #428, #422, and #402 for context. The main change involves modifying the alias generation and execution logic to avoid calling the shell directly for alias resolution and history writes.