nvbn/thefuck

EOL (end of line) issue on windows

Open

#1189 opened on Apr 26, 2021

View on GitHub
 (1 comment) (2 reactions) (0 assignees)Python (96,953 stars) (3,949 forks)batch import
help wantedwindows

Description

The output of thefuck --version (something like The Fuck 3.1 using Python 3.5.0 and Bash 4.4.12(1)-release):

The Fuck 3.30 using Python 3.8.3 and ZSH 5.8

Your system (Debian 7, ArchLinux, Windows, etc.):

Windows 10 1909, cygwin and conemu

How to reproduce the bug:

In my environment, the commands generated by thefuck ends with "^M". It seems it's because all the output of thefuck ends with "\r\n" on windows. However, the zsh can only process commands end with "\n".

For example, when I run eval $(thefuck --alias), the error message is

zsh: parse error near `^M'

Any idea about this issue? Thank you.

Contributor guide

Tech stack
pythonshell
Domain
cli
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Python development environmentBasic knowledge of line endings
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The issue is that on Windows, thefuck outputs commands ending with \r\n, but ZSH expects \n only. Look at how thefuck prints its output, likely in files like `thefuck/shells/` or `thefuck/main.py`. Check where newlines are added and ensure only \n is used on Unix like shells. Consider using os.linesep or a conditional based on platform. The fix may involve modifying the output of the alias command or the corrected command itself.