nvbn/thefuck

Doesn't handle pipes

Open

#108 opened on Apr 23, 2015

View on GitHubContributor guide
 (5 comments) (0 reactions) (0 assignees)Python (3,960 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (97,740 stars)
PR merge metrics
 (PR metrics pending)

Description

It looks like fuck doesn't handle pipes well. If I try to do this in Bash:

$ pss -ef | grep foo
-bash: pss: command not found
$ fuck
ps -ef | grep foo
ps: illegal argument: |
usage: ps [-AaCcEefhjlMmrSTvwXx] [-O fmt | -o fmt] [-G gid[,gid...]]
          [-g grp[,grp...]] [-u [uid,uid...]]
          [-p pid[,pid...]] [-t tty[,tty...]] [-U user[,user...]]
       ps [-L]

It looks like the command is executed in the wrong way, it seems like it's trying to execute it as a single command, instead of treating it as a line of input with potentially multiple commands.

Contributor guide

Research direction
Investigate the parsing logic in thefuck to see how it handles commands with pipes; ensure it treats the pipe as a command separator rather than passing the entire line to a single command.
Tech stack
python
Domain
cli
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPython
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60