nvbn/thefuck

Doesn't handle pipes

Open

#108 opened on Apr 23, 2015

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Python (96,953 stars) (3,949 forks)batch import
enhancementhelp wanted

Description

It looks like fuck doesn't handle pipes well. If I try to do this in Bash:

$ pss -ef | grep foo
-bash: pss: command not found
$ fuck
ps -ef | grep foo
ps: illegal argument: |
usage: ps [-AaCcEefhjlMmrSTvwXx] [-O fmt | -o fmt] [-G gid[,gid...]]
          [-g grp[,grp...]] [-u [uid,uid...]]
          [-p pid[,pid...]] [-t tty[,tty...]] [-U user[,user...]]
       ps [-L]

It looks like the command is executed in the wrong way, it seems like it's trying to execute it as a single command, instead of treating it as a line of input with potentially multiple commands.

Contributor guide

Tech stack
pythonshell
Domain
cli
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic PythonUnderstanding of shell piping
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate how thefuck parses and executes corrected commands. The issue suggests that commands with pipes are not handled correctly. Look at the command splitting logic in the shell modules (e.g., thefuck/shells/bash.py). Reproduce the bug using the provided example: 'pss ef | grep foo'. Check if the pipe argument is being passed as part of the command to ps. Consider adding handling to split on '|' and execute as a pipeline. Reference comments in the issue for additional context.