nunomaduro/phpinsights

[Laravel] Allow to set command parameters from config file

Open

#376 opened on Mar 10, 2020

View on GitHub
 (3 comments) (0 reactions) (0 assignees)PHP (308 forks)batch import
enhancementgood first issue

Repository metrics

Stars
 (5,092 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Q A
Bug report? no
Feature request? yes
Library version 1.13.0

Related with https://github.com/nunomaduro/phpinsights/issues/23 will be a great idea to allow set all commands parameters from config/insights.php when is used with php artisan insights.

Maybe something like:

'parameters' => '--format=json -d memory_limit=2000M -v',

or

'parameters' => [
    '--format=json',
    '-d memory_limit=2000M',
    '-v',
],

Parameters from command line must overwrite config parameters:

php artisan insights --format=html

And also an option to avoid use config will be great:

php artisan insights --no-config-parameters

Thanks!

Contributor guide

Research direction
Investigate how the package currently reads its configuration file and passes parameters to the underlying command. You should examine the config/insights.php file structure, the command class that handles artisan insights, and how it merges CLI arguments with default options. Implementing this feature will require modifying the command to accept an additional configuration key (e.g., 'parameters') and merging it with CLI arguments, ensuring CLI arguments take precedence. Also, add a no config parameters flag to skip reading config parameters.
Tech stack
php
Domain
cli
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PHPLaravel
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60