cred-registry-set 'set' silently clobbers a per-entry scrub:false opt-out

Open Beginner friendly
#96 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
90/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
python
Domain
security

Research direction

Start at proxy/cred-registry-set:137 and compare the set command with set-scrub, which already preserves the existing entry data. Verify that updating placement does not discard a previously configured scrub:false opt-out; the work is done when the entry fields are merged rather than silently replaced.

Written by the indexing model from the issue text.

Description

area:proxy security severity:low track:open-source

Severity: nit | Area: proxy | Track: open-source (from the 2026-09-19 build-loop security sweep, O2)

proxy/cred-registry-set:137set does reg.setdefault(name, {})[entry] = {"placement": placement}, replacing the whole entry dict and dropping a previously set scrub flag, while set-scrub uses setdefault and preserves placement. Fail-safe direction (losing scrub:false means more scrubbing), so nit only — but the two commands are asymmetric and the loss is silent. Make set merge instead of replace.

Dominant language
Python
Stars
1
Forks
0
Avg merge
4h 37m
Merged PRs (30d)
87

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ntindle/spark-vm

All issues in ntindle/spark-vm

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.