cred-ui: NAME_RE/ENTRY_RE non-string input drops the connection instead of 400
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 76/100
Research direction
Start with api_set, api_host, api_delete, and do_POST, then compare their validation with the host_ok hardening in issue #117. Verify that non-string name or entry values receive HTTP 400 responses and that the connection is not dropped, with no writes occurring before validation.
Written by the indexing model from the issue text.
Description
Same shape as the host_ok TypeError fixed in #117: api_set/api_host/api_delete call NAME_RE.match(name) / ENTRY_RE.match(entry) directly, so a non-string name/entry (e.g. JSON {"name": 123}) raises TypeError that escapes do_POST (catches only ValueError/RuntimeError) and drops the connection instead of answering 400. Pre-existing, fail-closed (no writes happen before validation), leaks nothing — apply the same isinstance hardening host_ok got, for consistency.
- Dominant language
- Python
- Stars
- 1
- Forks
- 0
- Avg merge
- 4h 37m
- Merged PRs (30d)
- 87
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ntindle/spark-vm
-
area:confirmd severity:medium track:open-source
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
area:proxy good first issue severity:low track:open-source
Difficulty 1/5 Under an hour Newbie friendliness 88/100
-
area:proxy security severity:low track:open-source
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
All issues in ntindle/spark-vm
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100