nteract/papermill

Absolutely not thread-safe usage of cwd

Open

#473 opened on Feb 16, 2020

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Python (402 forks)batch import
enhancementhelp wantednew-contributor-friendly

Repository metrics

Stars
 (5,381 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

This part of code is absolutely not thread-safe: https://github.com/nteract/papermill/blob/68580f79fd7cc037dd3908343e3a070c3140395b/papermill/execute.py#L91-L105

Why don't you use cwd parameter in nbclient.client.execute or at least copy this function? https://github.com/jupyter/nbclient/blob/8d5fc8caa0b27b308760e5a350369720c03efc8b/nbclient/client.py#L730-L750

Contributor guide

Research direction
Replace the unsafe os.chdir with the cwd parameter in nbclient.client.execute. Check papermill/execute.py lines 91-105 and modify to use the cwd argument as shown in the nbclient documentation.
Tech stack
python
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75