nsqio/nsq

nsqd: plan 9 compatibility

Open

#699 opened on Dec 27, 2015

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Go (25,788 stars) (2,898 forks)batch import
bughelp wanted

Description

The only alteration was the addition of internal/dirlock/dirlock_plan9.go as a mirror image of dirlock_windows.go (same empty functions) and, of course adding "!plan9" in dirlock.go. Maybe there is an easy way to implement directory locking in Plan 9, but at least it's established that nsq can be used as a Plan 9 application.

Contributor guide

Tech stack
go
Domain
backend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Gobasic file locking concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
This issue adds Plan 9 support to nsqd. The existing Windows implementation in internal/dirlock/dirlock windows.go serves as a template. The contributor should create internal/dirlock/dirlock plan9.go with the same empty functions and update the build constraint in dirlock.go to include Plan 9. No real locking is needed for now; just ensure compiles. Check if any other files need plan9 build tags.