nsqio/nsq

nsqd: statistics aren't recorded when client publishes to multiple topics

Open

#1,492 opened on Jul 5, 2024

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)Go (2,898 forks)batch import
bughelp wanted

Repository metrics

Stars
 (25,788 stars)
PR merge metrics
 (PR metrics pending)

Description

When a client sends messages to multiple topics, the statistics information can only output the results of one topic for a single client. After reviewing the code, I found that the problem lies in the break statement on line 305 of the client_v2.go file. Can you explain why this break statement is added?

for topic, count := range c.pubCounts {
	if len(topicName) > 0 && topic != topicName {
		continue
	}
	pubCounts = append(pubCounts, PubCount{
		Topic: topic,
		Count: count,
	})
	break   **//  What does this break statement do?**
}

Contributor guide

Research direction
Trace the code path in client v2.go where pubCounts is built and identify how the break statement prevents accumulation of counts for multiple topics.
Tech stack
go
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85