nsqio/nsq

nsqd: Use Klaus Post's compression libraries

Open

#1484 opened on Apr 15, 2024

View on GitHub
 (5 comments) (1 reaction) (0 assignees)Go (25,788 stars) (2,898 forks)batch import
help wantedperf

Description

We would quite like to use compression with NSQ to save on data transfer costs, but the CPU impact is higher than we'd like. Our experiments have shown that Klaus Post's compression libraries perform much better than the standard library Deflate and Google's Snappy, with the sweet spot appearing to be level 3 flate compressing our traffic to about 25% of its original size, but only incurring a CPU cost equivalent to Snappy.

Would there be any interest in taking a PR that makes this change?

Contributor guide

Tech stack
go
Domain
backendperformance
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Go programmingunderstanding of nsqd codebaseknowledge of compression algorithms
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the current compression implementation in nsqd, likely in the nsqd package. Review the linked compression library (github.com/klauspost/compress) and its flate/snappy compressors. Consider the benchmark results mentioned in the issue to validate performance gains. Discuss with maintainers on the issue thread about preferred approach and code guidelines.