nspcc-dev/neofs-testcases

Error messages in lock tests are not descriptive

Open

#759 opened on Mar 27, 2024

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)Python (18 forks)auto 404
I4S4U3buggood first issue

Repository metrics

Stars
 (4 stars)
PR merge metrics
 (PR metrics pending)

Description

tests.object.test_object_lock.TestObjectLockWithGrpc#test_expired_object_should_be_deleted_after_locks_are_expired tests.

Current Behavior

Got Failed: DID NOT RAISE <class 'Exception'> message if an object is not deleted.

Expected Behavior

Some understandable message about object not deleted after some time.

Possible Solution

Do some assert with a message. It is possible in pytest?

Steps to Reproduce

See https://rest.fs.neo.org/HXSaMJXk2g8C14ht8HSi7BBaiYZ1HeWh2xnWPGQCg4H6/1441-1711487340/index.html#suites/295ed2e000f8fa6f3ade59cc13b98615/3f2b8cbfd27db081/

Contributor guide

Research direction
Locate the failing test in the repository, specifically the `test expired object should be deleted after locks are expired` test in `tests.object.test object lock.TestObjectLockWithGrpc` class. Replace the current exception expectation with an assertion that includes a descriptive message, e.g., using `pytest.fail` or `assert` with a message. Ensure the test passes with meaningful output on failure.
Tech stack
python
Domain
testingbackend
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Pythonpytest
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90