nspcc-dev/neofs-node

Unify status usage in storage engine when object is missing

Open

#2,956 opened on Oct 1, 2024

View on GitHubContributor guide
 (0 comments) (1 reaction) (0 assignees)Go (49 forks)auto 404
I4S3U4enhancementgood first issue

Repository metrics

Stars
 (36 stars)
PR merge metrics
 (PR metrics pending)

Description

Is your feature request related to a problem? Please describe.

I'm always frustrated when we have both bool flags that mean the presence of an object in the engine and ErrObjectNotFound. Sometimes it is a flag and sometimes it is an error.

Describe the solution you'd like

It should either be error, or be a flag.

Describe alternatives you've considered

-

Additional context

Sometimes it is ok to have an error and sometimes we only accept a flag, it is unreliable. As for me, I wouldn't say I like using client statuses (that is where they are placed in SDK) in engines at all.

Contributor guide

Research direction
Search for all occurrences of ErrObjectNotFound and boolean flags like 'exists' or 'missing' in the storage engine. Compare usage patterns and propose a unified approach.
Tech stack
go
Domain
backenddatabase
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
GoStorage engine concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65