nspcc-dev/neofs-node

`neofs-adm` waits for potentially useless transactions

Open

#1,788 opened on Sep 15, 2022

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)Go (49 forks)auto 404
I4S3U4discussiongood first issueneofs-adm

Repository metrics

Stars
 (36 stars)
PR merge metrics
 (PR metrics pending)

Description

It is common practice to send some TXs, cache their hashes, and wait for their chain inclusion.

Adm CLI stops if one of the TX has not been persisted but does not stop if one of the TX was failed. Moreover, we return only the first not-HALT-err and drop other errors.

I suggest just stopping iterating on any non-HALT TX. It also would simplify the code.

Contributor guide

Research direction
Examine the waiting logic in `cmd/neofs adm/internal/modules/morph/initialize.go` lines 334-380. Understand the transaction handling and suggest a change to stop on any non HALT error. Consider simplifying the error handling.
Tech stack
go
Domain
backendblockchain
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45