nspcc-dev/neo-go

Cover example contracts with tests

Open

#3,648 opened on Oct 28, 2024

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)Go (108 forks)auto 404
I2S4U4enhancementgood first issuehelp wantedtest

Repository metrics

Stars
 (132 stars)
PR merge metrics
 (PR metrics pending)

Description

Is your feature request related to a problem? Please describe.

Some of our example contracts are not tested although they are complicated. In fact, only NNS contract has some unit-tests.

Describe the solution you'd like

At least complicated contracts like nft-nd and nft-d must be covered with neotest unit tests. Ideally, all of them must be covered with tests. First of all, these contracts are examples for other SC developers. Secondly, when we extend these contracts, we need to have a way to check that extension works properly, e.g. for situations like in https://github.com/nspcc-dev/neo-go/pull/3560.

Describe alternatives you've considered

No alternatives, tests are must-have.

Contributor guide

Research direction
Write unit tests for example contracts nft nd and nft d using the neotest framework. Study existing NNS contract tests for patterns.
Tech stack
go
Domain
blockchaintesting
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60