nspcc-dev/neo-go

Unify JSON encoders for stackitem

Open

#2,388 opened on Mar 5, 2022

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)Go (108 forks)auto 404
I4S2U4enhancementgood first issue

Repository metrics

Stars
 (132 stars)
PR merge metrics
 (PR metrics pending)

Description

Currently we have 2 ways to serialize a stack item to JSON. They behave similarly, so it may be beneficial to use a single function. Also write some benchmarks to ensure there is no performance penalty.

Contributor guide

Research direction
Identify the two JSON encoder functions for stack items in the codebase, analyze their similarities and differences, then design a unified function. Write benchmarks to compare performance before and after the change.
Tech stack
go
Domain
backendblockchain
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitGo
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75