nova-video-player/aos-AVP

find a way to pass subs to external player

Open

#140 opened on May 17, 2019

View on GitHub
 (10 comments) (0 reactions) (1 assignee)HTML (1,705 stars) (133 forks)batch import
Importantenhancementhelp wanted

Description

Reported by user, when using mxplayer as external player with nova, if an external subtitle file is present, it is not seen by mxplayer while it is seen when launching the video from esexplorer. Cf. mxplayer API/intents http://mx.j2inter.com/api for subs. Look into vlc intents as well https://wiki.videolan.org/Android_Player_Intents/ Seems to be specific for each player making it difficult not to specialize code. Good starting point is to look at PlayUtils.java in nova codebase. Contributions (pull requests) are welcome.

Contributor guide

Tech stack
javakotlinandroid
Domain
mobileapi
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Android development experienceKnowledge of Android intentsFamiliarity with MXPlayer and VLC APIs
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Start by examining PlayUtils.java in the nova codebase to understand current intent handling for external players. Research MXPlayer and VLC intents documentation to see how subtitle files can be passed as extras. Look at how ES File Explorer accomplishes this, and consider implementing a mapping for different players. Check issue comments for any additional insights or attempted solutions.
find a way to pass subs to external player · nova-video-player/aos-AVP#140 | Good First Issue