nolanlawson/cordova-plugin-sqlite-2

Android: should throw meaningful errors when the 1MB CursorWindow limit is reached

Open

#46 opened on Dec 18, 2016

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (29 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (168 stars)
PR merge metrics
 (PR metrics pending)

Description

Currently these errors just get swallowed, e.g.: https://github.com/pouchdb/pouchdb/issues/5413

We just return empty results which causes bugs later on down the line that are hard to diagnose: https://github.com/nolanlawson/cordova-plugin-sqlite-2/blob/33afdef8409b8782b7a82ca7d59270e7e11541dd/src/android/SQLitePlugin.java#L93-L96

Contributor guide

Research direction
Examine the SQLitePlugin.java file, specifically the execute method, and identify where the CursorWindow limit exception is swallowed. Implement a try catch block around the database query to catch the exception and throw a meaningful error message.
Tech stack
javascriptjava
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitAndroid SDK
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70