nodejs/undici

Improve tests with more checks for unexpected `'disconnect'`

Open

#251 opened on Jul 11, 2020

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (444 forks)batch import
enhancementgood first issue

Repository metrics

Stars
 (5,319 stars)
PR merge metrics
 (Avg merge 2d 10h) (82 merged PRs in 30d)

Description

Some of our tests might emit disconnect, reconnect and then pass even though a disconnect was not expected.

Add more assertions (t.fail()) to catch this if it happens.

Contributor guide

Research direction
Examine the existing test files in the undici repository, particularly those that might emit unexpected disconnect events. Understand the testing patterns (likely using tap). Identify areas where a disconnect could occur unexpectedly and add `t.fail()` assertions to catch such cases.
Tech stack
nodejsjavascript
Domain
testing
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Node.jsGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80