nodejs/undici

Improve tests with more checks for unexpected `'disconnect'`

Open

#251 opened on Jul 11, 2020

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (5,319 stars) (444 forks)batch import
enhancementgood first issue

Description

Some of our tests might emit disconnect, reconnect and then pass even though a disconnect was not expected.

Add more assertions (t.fail()) to catch this if it happens.

Contributor guide

Tech stack
javascriptnodejs
Domain
backendtesting
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic Node.js testing knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
Search for test files in the 'test' directory of the undici repository. Identify tests that handle 'disconnect' events. Add a 't.fail()' call inside an event listener for 'disconnect' where the event is unexpected. For example, in tests that simulate reconnection, ensure that a disconnect event causes the test to fail unless it is expected. Look at existing patterns in test files using tap or tape.