nodejs/undici

Filter tls options

Open

#236 opened on Jun 28, 2020

View on GitHubContributor guide
 (7 comments) (0 reactions) (0 assignees)JavaScript (444 forks)batch import
enhancementgood first issue

Repository metrics

Stars
 (5,319 stars)
PR merge metrics
 (PR metrics pending)

Description

Determine which tls options actually make sense to forward to tls.connect and throw if any other is provided (e.g. allowHalfOpen).

Contributor guide

Research direction
Examine the existing codebase to see how TLS options are currently passed to tls.connect. Identify which options are valid for tls.connect and which are not (e.g., allowHalfOpen). Implement a filter that throws an error for invalid options.
Tech stack
javascriptnodejs
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Node.jsTLS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60