nodejs/undici

Filter tls options

Open

#236 opened on Jun 28, 2020

View on GitHub
 (6 comments) (0 reactions) (0 assignees)JavaScript (5,319 stars) (444 forks)batch import
enhancementgood first issue

Description

Determine which tls options actually make sense to forward to tls.connect and throw if any other is provided (e.g. allowHalfOpen).

Contributor guide

Tech stack
javascriptnodejs
Domain
backendapi
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Node.js basicsTLS conceptsUnderstanding of undici codebase
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Examine the undici source code to find where TLS options are currently passed to `tls.connect`. Likely in a connection file (e.g., `lib/connect.js` or similar). Review Node.js documentation for `tls.connect` to list valid options. Then implement a filter that allows only valid TLS options and throws an error for invalid ones like `allowHalfOpen`. Consider adding tests for the new validation.