nodejs/node

test_runner: do not read from `process.argv` and `process.cwd()` in run()

Open

#53867 opened on Jul 16, 2024

View on GitHub
 (13 comments) (5 reactions) (0 assignees)JavaScript (117,218 stars) (35,535 forks)batch import
good first issuetest_runner

Description

Currently the codebase for https://github.com/nodejs/node/blob/362afa52ebe462a39874915e5e70d261db153c58/lib/internal/test_runner/runner.js#L472 accesses some poperties of process, capturing some options there. However, we also expose run() to the end users, therefore we should capture all this information in https://github.com/nodejs/node/blob/362afa52ebe462a39874915e5e70d261db153c58/lib/internal/main/test_runner.js#L68 and pass it down to run() as options.

Contributor guide

Tech stack
javascriptnodejs
Domain
backendtesting
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
understanding of Node.js internalsknowledge of process.argv and process.cwd()familiarity with test runner module
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
The issue requires moving the capture of process.argv and process.cwd() from runner.js to test runner.js and passing them as options to run(). Examine the code in lib/internal/test runner/runner.js around line 472 and lib/internal/main/test runner.js around line 68 to understand current usage. Ensure that all dependencies on process properties are relocated and passed as parameters. No linked PRs or additional context in comments.