nodejs/node

Re-enable test-ubsan.yml

Closed

#52,753 opened on Apr 29, 2024

View on GitHubContributor guide
 (2 comments) (0 reactions) (0 assignees)JavaScript (35,535 forks)batch import
help wantedmetastale

Repository metrics

Stars
 (117,218 stars)
PR merge metrics
 (Avg merge 18d 17h) (219 merged PRs in 30d)

Description

During the latest Node.js major release (https://github.com/nodejs/node/pull/52505) we have had to disable test-ubsan.yml due to failing tests on a recent V8 update (https://github.com/nodejs/node/pull/52560).

I have tried to make it work, but due to the short time frame I had to fix it, we have decided to simply disable it for now.

Some insights:

  • It seems clang provides a better output and some docs we could use in the suppressions file.
    • Changing from g++ to clang for UBSAN will require changing all the suppression file

Contributor guide

Research direction
Look at the V8 update commit (nodejs/node#52560) to identify failing tests. Run test ubsan locally with clang to get better error messages. Update the suppression file accordingly.
Tech stack
javascriptcppnodejsgithub actions
Domain
ci cdtestingbackend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++GitNode.js build systemUBSAN
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40