nodejs/node

fs: utf8 fast paths don't accept all valid utf8 values

Open

#49,888 opened on Sep 26, 2023

View on GitHub
 (11 comments) (1 reaction) (0 assignees)JavaScript (35,535 forks)batch import
fsgood first issue

Repository metrics

Stars
 (117,218 stars)
PR merge metrics
 (Avg merge 18d 17h) (219 merged PRs in 30d)

Description

UTF8 and UTF-8 are also valid but not accepted by any existing utf8 fast paths (#48658, #49884)

Contributor guide

Research direction
Inspect the utf8 fast path implementation in fs and identify where valid UTF 8 values like 'UTF8' and 'UTF 8' are not accepted. Look for encoding validation logic and compare with supported encodings.
Tech stack
nodejs
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65