nodejs/node

Writable does not check if stream has been destroyed during _final and _write

Open

#39030 opened on Jun 14, 2021

View on GitHub
 (21 comments) (1 reaction) (0 assignees)JavaScript (117,218 stars) (35,535 forks)batch import
good first issuesemver-majorstream

Description

Not sure if this is a problem but I think we should at least add a comment in the code that this case has been considered.

Contributor guide

Tech stack
javascriptnodejs
Domain
backenddocumentation
Issue type
documentation
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic knowledge of Node.js streams
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Examine the source file `lib/ stream writable.js` in the Node.js repository, focusing on the ` write` and ` final` methods. Look for any existing checks for `destroyed` state and comments. The issue requests adding a comment to clarify the behavior when the stream is destroyed during these calls. Review the discussion in the issue comments for any specific concerns or suggested wording. Ensure the comment is added in the appropriate location within each method.