nodejs/node

Writable does not check if stream has been destroyed during _final and _write

Open

#39,030 opened on Jun 14, 2021

View on GitHub
 (21 comments) (1 reaction) (0 assignees)JavaScript (35,535 forks)batch import
good first issuesemver-majorstream

Repository metrics

Stars
 (117,218 stars)
PR merge metrics
 (Avg merge 18d 17h) (219 merged PRs in 30d)

Description

Not sure if this is a problem but I think we should at least add a comment in the code that this case has been considered.

Contributor guide

Research direction
Investigate the final and write methods in the Writable stream class in Node.js core to determine if a destroyed state check is missing, and consider adding a comment or fix.
Tech stack
nodejs
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60