nodejs/node

No content length on DELETE and OPTIONS

Open

#27,880 opened on May 26, 2019

View on GitHub
 (26 comments) (0 reactions) (0 assignees)JavaScript (35,535 forks)batch import
confirmed-bughelp wantedhttp

Repository metrics

Stars
 (117,218 stars)
PR merge metrics
 (Avg merge 18d 17h) (219 merged PRs in 30d)

Description

Looking through https://github.com/nodejitsu/node-http-proxy/commit/8a24a1e18f384d29a125eda1d2311bdd8ec66871 and reading through the node code. I do believe we have an unhandled case.

I believe we are missing something here: https://github.com/nodejs/node/blob/master/lib/_http_outgoing.js#L349

To ensure content-length and transfer-encoding are correct.

Am I on to something or should I drop this?

Contributor guide

Research direction
Investigate the missing content length handling for DELETE and OPTIONS methods in http outgoing.js. Trace the logic around line 349 in the Node.js source and ensure consistency with the fix in commit 8a24a1e18f.
Tech stack
javascript
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
GitNode.js internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60