nodejs/node

No content length on DELETE and OPTIONS

Open

#27,880 opened on May 26, 2019

View on GitHub
 (26 comments) (0 reactions) (0 assignees)JavaScript (117,218 stars) (35,535 forks)batch import
confirmed-bughelp wantedhttp

Description

Looking through https://github.com/nodejitsu/node-http-proxy/commit/8a24a1e18f384d29a125eda1d2311bdd8ec66871 and reading through the node code. I do believe we have an unhandled case.

I believe we are missing something here: https://github.com/nodejs/node/blob/master/lib/_http_outgoing.js#L349

To ensure content-length and transfer-encoding are correct.

Am I on to something or should I drop this?

Contributor guide

Tech stack
javascriptnodejs
Domain
backendapi
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
HTTP protocol basicsNode.js HTTP module internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Investigate the referenced commit (8a24a1e) and the http outgoing.js file, specifically around line 349. Determine if DELETE and OPTIONS methods should set content length or transfer encoding headers. Check Node.js HTTP spec compliance. Review the 26 comments for any conclusions or proposed fixes.