nodejs/node

http socket might get reset instead of normal close while handling timeout

Open

#26,166 opened on Feb 17, 2019

View on GitHub
 (4 comments) (5 reactions) (0 assignees)JavaScript (117,218 stars) (35,535 forks)batch import
help wantedhttp

Description

  • Version: v10.15.1
  • Platform: Linux 0fe3a1d57e94 4.9.125-linuxkit #1 SMP Fri Sep 7 08:20:28 UTC 2018 x86_64 GNU/Linux
  • Subsystem: http,net

We were experiencing unexpected dropped connections between AWS ALB and nodejs application resulting in 502 errors from load balancer.

Managed to replicate a condition when nodejs abnormally closes socket with RST packet instead of normal FIN packets.

Here's exact conditions:

server.timeout = 10 * 1000;
server.keepAliveTimeout = 0;

image

We kept doing requests to the same connection every 10 seconds to trigger the condition.

Note that data was received and acknowledged, but instead of handling data or closing socket in a normal way nodejs reset the tcp connection.

Contributor guide

Tech stack
javascriptnodejs
Domain
backendperformance
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Node.js HTTP moduleTCP socket behaviorNode.js core internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
The bug occurs in the Node.js HTTP server when `server.timeout` is set and `keepAliveTimeout` is 0, causing a TCP RST instead of FIN. Investigate the socket hangup logic in `lib/ http server.js` and `lib/net.js`. Check the issue comments for any existing analysis or patches. Reproduce using the provided conditions and examine socket states to determine where the reset is triggered.
http socket might get reset instead of normal close while handling timeout · nodejs/node#26166 | Good First Issue