nodejs/node

Run tests with OPENSSL_CONF set to embedded openssl.cnf

Open

#24373 opened on Nov 15, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (117,218 stars) (35,535 forks)batch import
help wantedopenssltest

Description

  • Version: <= 10.13.0
  • Platform: Linux

when building with the --shared-openssl flag, it is highly probable that the openssl.cnf used by the shared library will be different than the one present in Node.js source code, resulting in several test failures. Typically, on debian, openssl is configured with stricter options regarding key length and TLS versions. It is very easy to avoid any test failure, though, by setting this environment variable when running tests: OPENSSL_CONF=./deps/openssl/openssl/apps/openssl.cnf

Contributor guide

Tech stack
nodejsjavascript
Domain
testingbackend
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Understanding of Node.js test suiteBasic knowledge of OpenSSL configuration
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
The issue suggests setting the OPENSSL CONF environment variable to the embedded openssl.cnf file when running tests with shared openssl. This can be implemented by modifying the test runner configuration, possibly in the Makefile or test scripts. Look at the test configuration files in the repository, such as 'Makefile' or 'test/common/' to add the environment variable.