nodejs/node

Embedding: static nodejs variables are not set to default

Open

#21,653 opened on Jul 4, 2018

View on GitHub
 (12 comments) (0 reactions) (0 assignees)JavaScript (35,535 forks)batch import
c++embeddinghelp wantedstale

Repository metrics

Stars
 (117,218 stars)
PR merge metrics
 (Avg merge 18d 17h) (219 merged PRs in 30d)

Description

  • Version: v8.x (maybe any)
  • Platform: MS Windows 7
  • Subsystem: embedding

I use nodejs to run javascript code in my application. And I have found that after running script from code, script from file will not run. It is caused by unpredicted value of eval_string static variable, that was not set to nullptr at previous run, and bootstrap tries to run code instead of file. Also I think, some other static variables can interrupt running scripts too.

Contributor guide

Research direction
Investigate the initialization of static variables in the Node.js embedding API, particularly the `eval string` variable, and ensure they are reset to default values when switching between script execution modes.
Tech stack
javascriptcpp
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Node.js embeddingGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40