nodejs/node

Merge streams handling code for http2 streams & net.Socket

Open

#19,060 opened on Feb 28, 2018

View on GitHub
 (27 comments) (0 reactions) (0 assignees)JavaScript (117,218 stars) (35,535 forks)batch import
help wantedhttp2net

Description

Hey :)

It would be great if we could unify all the code from net and http2 that is only concerned with pushing data to/from the underlying stream, ideally into a common base class of net.Socket and Http2Stream, so that we could also maybe port some of the other native streams (zlib, fs) to using StreamBase on the native side & generally just share a lot of code.

This is probably not an easy task, and probably not doable in one pass, because the http2 and net implementations are always just slightly different, but if anybody wants to try to start working on this, feel free to reach out by commenting here.

Contributor guide

Tech stack
javascriptnodejscpp
Domain
backend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
5
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
Understanding of Node.js stream internalsC++ and JavaScript experienceFamiliarity with net and http2 modules
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
10
Research direction
This issue proposes merging stream handling code between net.Socket and Http2Stream. To start, investigate the current implementations in lib/net.js and lib/http2.js, and the native StreamBase class in src/stream base.cc. Look for duplicated logic in OnStreamRead and Write operations. The discussion in comments may provide additional insights.
Merge streams handling code for http2 streams & net.Socket · nodejs/node#19060 | Good First Issue