nodejs/node

repl: no RegExp side effects

Open

#18,931 opened on Feb 22, 2018

View on GitHub
 (5 comments) (0 reactions) (1 assignee)JavaScript (35,535 forks)batch import
help wantednever-stalereplstale

Repository metrics

Stars
 (117,218 stars)
PR merge metrics
 (Avg merge 18d 17h) (219 merged PRs in 30d)

Description

$ ./out/Release/node 
> RegExp.$_
'\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000'

Caused by the repl trying to fix up the side effects to RegExp.$1 toRegExp.$9. :-)

Contributor guide

Research direction
Examine the REPL code in the Node.js source that handles RegExp static properties (`RegExp.$1` to `RegExp.$9`) and `RegExp.$ ` to understand why it is incorrectly setting these values. Look for the relevant files in `lib/repl.js` or similar, and trace the path from REPL evaluation to where side effects occur. Consider how to preserve the original state or avoid setting these properties.
Tech stack
javascriptnodejs
Domain
clideveloper experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptNode.js basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65