Remove git requirement for test suite?

Open Beginner friendly
#58 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
76/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Active
Tech stack
cmake, cpp, git
Domain
build-system, testing

Research direction

Start with the git check at line 90 of CMakeLists.txt and inspect the test-suite configuration that follows it. Confirm whether any test setup invokes git, then remove the requirement if it is unused and verify that the test suite still configures and runs without git available.

Written by the indexing model from the issue text.

Description

Hello,

Currently the build system enforces git is available to run the test suite:

https://github.com/nodejs/merve/blob/12945b6c3c082878288b5e5804eb7bd68a3398a9/CMakeLists.txt#L90

But it does not look like the test suite is actually using git, unless I'm missing something. If correct, the requirement on git should be dropped (it is problematic for reproducible builds where git/repo metadata is unavailable such as in Guix).

Dominant language
C++
Stars
63
Forks
11
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from nodejs/merve

All issues in nodejs/merve

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.