nodejs/llnode

no coverage for "v8 nodeinfo"

Open

#423 opened on Oct 1, 2022

View on GitHubContributor guide
 (4 comments) (0 reactions) (0 assignees)C++ (101 forks)github user discovery
good first issue

Repository metrics

Stars
 (1,167 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

According to the coverage report there are no tests for v8 nodeinfo. Two options:

  1. Remove it. It is a couple hundred lines of code, and how often do you get a coredump where you don't know the version of Node.js you were running?
  2. Add a test for it.

Contributor guide

Research direction
Examine the existing test infrastructure and find how to add a test for the 'v8 nodeinfo' command. Consider either writing a test or gathering consensus to remove the code.
Tech stack
nodejs
Domain
backendtooling
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Node.jslldb
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60